Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dummy Data for /shop/get/ #133

Merged
merged 4 commits into from
Dec 16, 2023
Merged

Dummy Data for /shop/get/ #133

merged 4 commits into from
Dec 16, 2023

Conversation

npunati27
Copy link
Contributor

@npunati27 npunati27 commented Dec 8, 2023 •
edited by AydanPirani
Loading

Added a new database "points" with a collection for item data, "items" and quantity "quantities".

GET: /shop/ returns a list of all shop items (currently dummy data)
POST: /shop/ puts a new item into both collections
DELETE: /shop/:ITEMID deletes an item by itemId
PUT: /shop/quantity updates quantity of an item
PUT: /shop/item updates item info of an item

@lasyaneti
Copy link
Contributor

lasyaneti commented Dec 11, 2023 •
edited by AydanPirani
Loading

  • DB changes
  • GET: /shop/
  • POST: /shop/
  • DELETE: /shop/:ITEMID
  • PUT: /shop/quantity
  • PUT: /shop/item

lasyaneti
lasyaneti requested changes Dec 11, 2023
View reviewed changes
Copy link
Contributor

@lasyaneti lasyaneti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you make a separate branch with just GET for now since this is urgent for mobile teams.

See vercel logs for Unhandled Promise Rejection errors with POST and PUT

@AydanPirani AydanPirani changed the title point shop part 2 Dummy Data for /shop/get/ Dec 16, 2023
@AydanPirani AydanPirani merged commit 0d5f366 into main Dec 16, 2023
5 checks passed
@AydanPirani AydanPirani deleted the dev/nikhita/point-shop branch December 16, 2023 18:58
@AydanPirani AydanPirani mentioned this pull request Dec 16, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lasyaneti lasyaneti lasyaneti approved these changes

@AydanPirani AydanPirani Awaiting requested review from AydanPirani

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@npunati27 @lasyaneti @AydanPirani