Committing 2023 Code to Master #530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumping deployment target - Louis/swiftUI deprecations
Onboarding page migration complete.
Google Maps setup complete.
Fixed deprecations
Registered Montserrat text to Info.plist and updated text attributes
Added in Montserrat
Updated refresh animation json file.
Updated leaderboard cells, including fixing the flow controller add-on
* feat: Lottie file with text * chore: add files via commit
Removed logout button from view and changed the error message color to white.
…ile ticket when food diet not fit in category (#516)
Fixed issue where the bottom of certain letters such as 'y' get cut off.
* Add everything in Final Doc White X on QR Fix Dietary layout Alert now has name and dietary Profile Reloads on QR scan and loading view Name truncates * Add deinit * Fix random alert not having data
* removed text * fix: memories made text
* fix: event detail card locations * fix: event bubble cell locations
lasyaneti
requested review from
PatrickKan,
jeffkim2001 and
ashayp22
as code owners
ashayp22
approved these changes
Jul 18, 2023
There was a problem hiding this comment.
Looks good to me. While we have merged all commits into master in the past, commit hisotyr is preserved in dev so it makes sense to me to squash all commits and merge one commit titled "2023 app" or "<enter iOS app version" or something along the lines of that.
I'm also noticing that we forgot to add Bump commits like in the past. That's ok, but it's good practice to do this for 2024.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ios hackillinois 2023 end of an era