Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

made hamburger menu for navbar #18

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

mustachemo
Copy link
Collaborator

To make centering the nav-items easier I had to "npm install minireset.css" there was an issue where we used position: absolute for the nav-items to keep the white space from appearing above the navbar. This is not scalable. The problem was with our reset/normalizing of the css (look it up for detail). By having a reset file, the white space problem was solved and it allowed me to readjust the nav-items easier and with using position: absolute, which is useful as it is scalable.

Using the minireset, the site now looks a bit better, it doesn't look as close up if you look closely. The hacked header is a bit more far away which will need adjusting, but everything else is the same (and I think it looks. abit better)

@AlissonRoss
Copy link
Member

AlissonRoss commented Oct 20, 2023

There seems to be an error on my end while trying to run the code. Did you happen to install minireset.css as a dependency? npm install minireset.css
We might need to add this as a dependency

image

As for the hamburger menu, you can look into MUI Components: https://mui.com/material-ui/react-app-bar/
We can discuss this more in the next meeting. :) Thank you for your contributions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants