Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jason cheng (#1 #4) #18

Merged
merged 7 commits into from
Jan 15, 2020
Merged

Jason cheng (#1 #4) #18

merged 7 commits into from
Jan 15, 2020

Conversation

JasonCheng1
Copy link

Fixed Issue: Hello World? and Noisy Console!

@mjrb mjrb changed the title Jason cheng Jason cheng (#1 #4) Jan 8, 2020
Copy link
Member

@mjrb mjrb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a small tweak

challenge/src/App.jsx Outdated Show resolved Hide resolved
@mjrb
Copy link
Member

mjrb commented Jan 15, 2020

@JasonCheng1 when you get a chance, could you just remove the console.log entirely, and then I can merge this in.
Thanks

@JasonCheng1
Copy link
Author

@mjrb Still learning git, I forgot to push my changes a while back

@mjrb
Copy link
Member

mjrb commented Jan 15, 2020

Np, learning is always good

Copy link
Member

@mjrb mjrb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

badda bing

@mjrb mjrb merged commit d033cd3 into master Jan 15, 2020
@mjrb mjrb deleted the JasonCheng branch January 15, 2020 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants