fixed up user_profile.py #6
Conversation
.vscode/settings.json
Outdated
| "python.linting.pylintEnabled": false, | ||
| "python.linting.flake8Enabled": true, | ||
| "python.linting.pylamaEnabled": false | ||
| } |
There was a problem hiding this comment.
I'll add settings.json to .gitignore
I'm using something called black for linting
There was a problem hiding this comment.
black is one way of doing it, we can also look into some other options like pylint. We should figure out which linting tool will be the best for our needs.
There was a problem hiding this comment.
im using black right now but lmk if you find anything better
app/config.py
Outdated
| DIRECTOR_CREDENTIALS = { | ||
| "email": "", | ||
| "password": "" | ||
| } | ||
|
|
||
|
|
||
| # uri should contain auth and default database(database name) | ||
| DB_URI = "" | ||
| DB_URI = "mongodb://127.0.0.1:27017/hackrd" |
There was a problem hiding this comment.
I can make a .gitignore for this page so we don't expose any credentials.
There was a problem hiding this comment.
We should implement a config.example.py like LCS, so that each developer stores their own copy of the config.py file locally, and the repo only maintains a template file.
There was a problem hiding this comment.
Can we remove config.py so that github doesn't track it
There was a problem hiding this comment.
Yup let's remove this file, you already added in config.example.py so we're good to go!
app/config.py
Outdated
| DIRECTOR_CREDENTIALS = { | ||
| "email": "", | ||
| "password": "" | ||
| } | ||
|
|
||
|
|
||
| # uri should contain auth and default database(database name) | ||
| DB_URI = "" | ||
| DB_URI = "mongodb://127.0.0.1:27017/hackrd" |
There was a problem hiding this comment.
We should implement a config.example.py like LCS, so that each developer stores their own copy of the config.py file locally, and the repo only maintains a template file.
app/config.py
Outdated
| DIRECTOR_CREDENTIALS = { | ||
| "email": "", | ||
| "password": "" | ||
| } | ||
|
|
||
|
|
||
| # uri should contain auth and default database(database name) | ||
| DB_URI = "" | ||
| DB_URI = "mongodb://127.0.0.1:27017/hackrd" |
There was a problem hiding this comment.
Can we remove config.py so that github doesn't track it
app/config.py
Outdated
| DIRECTOR_CREDENTIALS = { | ||
| "email": "", | ||
| "password": "" | ||
| } | ||
|
|
||
|
|
||
| # uri should contain auth and default database(database name) | ||
| DB_URI = "" | ||
| DB_URI = "mongodb://127.0.0.1:27017/hackrd" |
There was a problem hiding this comment.
Yup let's remove this file, you already added in config.example.py so we're good to go!
| team_size = len(coll("teams").find_one({"_id": team_name})['members']) | ||
| team_name = coll("teams").find_one({"members": {"$all": [email]}}, {"_id"})[ | ||
| "_id" | ||
| ] |
There was a problem hiding this comment.
black has some weird formatting lol
There was a problem hiding this comment.
(you don't actually need to do anything here, just a comment)
Let me know if this is what you want for user_profile.py