Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add pre-commit and autoformatting to the code #22

Merged
merged 3 commits into from Oct 25, 2022
Merged

feat: add pre-commit and autoformatting to the code #22

merged 3 commits into from Oct 25, 2022

Conversation

thenishantsapkota
Copy link
Contributor

No description provided.

hitblast
hitblast approved these changes Oct 25, 2022
View reviewed changes
Copy link
Collaborator

@hitblast hitblast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks decent! I guess ignoring string normalisation would be good because double quotes sometimes feel awkward but it'll be fine for now.

@hitblast hitblast added the enhancement New feature or request label Oct 25, 2022
@hitblast
Copy link
Collaborator

@thenishantsapkota Could you resolve the merge conflicts though?

@thenishantsapkota
Copy link
Contributor Author

@thenishantsapkota Could you resolve the merge conflicts though?

Done!

@hitblast
Copy link
Collaborator

@thenishantsapkota Thanks! Giving this a merge. 👍

@hitblast hitblast merged commit 37194c0 into HackSquadDev:main Oct 25, 2022
@thenishantsapkota thenishantsapkota deleted the feat/pre-commit branch October 25, 2022 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hitblast hitblast hitblast approved these changes

Assignees

@thenishantsapkota thenishantsapkota

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@thenishantsapkota @hitblast