react-week2 assignment #22
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Check the assignment rules - I believe the fake data directory should no longer be here?
singhshemona
suggested changes
Jan 14, 2024
| return response.json(); | ||
| }) | ||
| .then((data) => { | ||
| setLoading(false); |
There was a problem hiding this comment.
I don't see the loading set to true anywhere?
| <div className="app"> | ||
| <Header category={category} setCategory={setCategory} /> | ||
| {loading ? ( | ||
| <div>Loading...</div> |
There was a problem hiding this comment.
I'm not sure this will show, due to my comment above
There was a problem hiding this comment.
the loading message ("Loading...") will be displayed when the loading state is true. The loading state is initially set to true, and it's only set to false after the successful completion of the API call.
singhshemona
approved these changes
Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.