Liz García - React Week 2 - Assignments #27
Conversation
liz-garcia
changed the title
| if (!productDetails) { | ||
| return <p>Loading...</p>; | ||
| } |
There was a problem hiding this comment.
I don't actually see a "Loading" text come up when I slow down the internet connection. It might be that productDetails needs to be cleared before it can be set again?
There was a problem hiding this comment.
Hi mentor! I inspected this in my code and in the deployed link, and I do see the 'Loading...' text showing up on screen, it appears for a fraction of a second in the top-left corner, in this link: https://ecommerce-app-week2.netlify.app/
| .product-view h1 { | ||
| font-size: 29px; | ||
| } | ||
|
|
||
| .product-info p { | ||
| margin: 8px; | ||
| font-size: 19px; | ||
| } | ||
|
|
||
| .product-details .image-container { | ||
| height: 400px; | ||
| } |
There was a problem hiding this comment.
I think something is off with the indentation here
| const Home = ({ selectedCategory, setSelectedCategory }) => ( | ||
| <> | ||
| <CategoryList | ||
| selectedCategory={selectedCategory} | ||
| setSelectedCategory={setSelectedCategory} | ||
| /> | ||
| <ProductList selectedCategory={selectedCategory} /> | ||
| </> | ||
| ); | ||
|
|
There was a problem hiding this comment.
Maybe this should be in a separate file in the components folder? Bit easier to read that way
|
Hello mentor @singhshemona 😊 I have implemented the requested changes. I also explored the issue with the "Loading..." text message, but in my link it is working fine, it appears just for a second, at the top left-corner of the screen here: https://ecommerce-app-week2.netlify.app/ If there's anything else I should do, please let me know. |
Hello mentor @singhshemona,
Deployed project for React week 2 is here: Ecommerce app
Thank you for your advice and guidance.
By the way, happy holidays & Happy new year! 😊🎉✨