<Mohammed> - React - Week3> #34
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
durw4rd
approved these changes
Jan 23, 2024
There was a problem hiding this comment.
Hey Mo, it almost feels as if I'm letting you down but I don't have any constructive feedback beyond praise for the awesome work you did on this homework! The code is clean, the app more than meets all the requirements for the week. My personal highlights:
- I really like how you created a custom hook from the
FavoritesContext. - Nice use of the old state variable within the
useStatehook in several places. - Great that you are storing favorites in local storage so they persist across page reloads!
👏 👏 👏
|
Thank you so much @durw4rd , thanks to your feedback on the previous ones which made understanding the concepts easier. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deployed app:
https://react-week3-shop.netlify.app/