homework3 -class45-sanazzarei #37
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
singhshemona
suggested changes
Jan 14, 2024
| setFavorites([...favorites, productId]); | ||
| } | ||
| }; | ||
| console.log(favorites); |
| } | ||
|
|
||
| if (error) { | ||
| return <div>Sorry, we have an error: {error}</div>; |
There was a problem hiding this comment.
good job letting the user know about the error!
Comment on lines
+26
to
+27
| } catch (error) { | ||
| console.error("Error:", error); |
There was a problem hiding this comment.
I think lines 18-19 already handle the error, you might not need this?
There was a problem hiding this comment.
i thought response.ok checks if the HTTP request was successful, while the catch block handles any other potential errors during the process.
| } | ||
|
|
||
| const { data, isLoading, error } = useFetch(url); | ||
| const products = data; |
There was a problem hiding this comment.
why the rename to products? If it's to make it more clear maybe the useFetch should export products instead of data. this is just a suggestion, no need to change
There was a problem hiding this comment.
I think this folder can be removed
singhshemona
approved these changes
Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.