react1-week3/niloufar #274
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aina21
reviewed
Apr 4, 2024
| const {data : initialTodo, error} = useSWR(url , fetcher); | ||
|
|
||
| const [todos, setTodos] = useState<Todo[]>([]); | ||
| const [isLoading, setIsLoading] = useState<boolean>(true); |
There was a problem hiding this comment.
You can utilize the isLoading status directly from useSWR instead of creating a separate state for isLoading.
aina21
reviewed
Apr 4, 2024
| } | ||
| }, [initialTodo]); | ||
|
|
||
| const deleteTodo = (id: number) => { |
There was a problem hiding this comment.
I suggest moving the deleteTodo function into the TodoList component as you're not depending on it out of the component scope.
aina21
reviewed
Apr 4, 2024
| setNewTodoItem({ ...newTodoItem, deadline: e.target.value }); | ||
| }; | ||
|
|
||
| const addNewTodo = () => { |
There was a problem hiding this comment.
You could add a condition to check if the new item is empty before adding it to the list. This prevents empty items from being included.
aina21
approved these changes
Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.