validate team code #31
Conversation
| const results = await knex('Teams').where({ team_code: teamCode }); | ||
|
|
||
| if (results.length === 0) { | ||
| throw new Error('Team not found'); |
There was a problem hiding this comment.
Perhaps would be better to not throw an error, but to send a response with 404 code?
There was a problem hiding this comment.
I cannot see the pic
There was a problem hiding this comment.
we have something like this when user enter the wrong code
There was a problem hiding this comment.
I saw this, but I mean in terms of the API, it is perhaps not the best to throw an error here, because and error did not happen.
"The HTTP 404 Not Found response status code indicates that the server cannot find the requested resource."
…etroRealm into implementIndexPage
| const results = await knex('Teams').where({ team_code: teamCode }); | ||
|
|
||
| if (results.length === 0) { | ||
| throw new Error('Team not found'); |
There was a problem hiding this comment.
I saw this, but I mean in terms of the API, it is perhaps not the best to throw an error here, because and error did not happen.
"The HTTP 404 Not Found response status code indicates that the server cannot find the requested resource."
Description
implemented team code validation
Fixes # (issue)
How to test?
Please provide a short summary how your changes can be tested?
Checklist