Dashboard navbar/frontend #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I have done all the edits and pulled the last changes of the featured branch and everything works correctly.
shpomp
approved these changes
Apr 19, 2024
ddobby94
reviewed
Apr 21, 2024
| aria-describedby="modal-modal-description" | ||
| > | ||
| <Box sx={style} className="modal-container"> | ||
| {' '} |
| @@ -13,28 +15,59 @@ export const AddTeamMemberModal = ({ | |||
| if (!showAddModal) { | |||
| return null; | |||
| } | |||
|
|
|||
| const style = { | |||
There was a problem hiding this comment.
I think this can be moved to the css file 🤔
There was a problem hiding this comment.
You already have the .modal-container css class
| list-style-type: none; /* Remove default list styles */ | ||
| padding: 0; /* Remove default padding */ | ||
| background: var(--primary-background-color); | ||
| padding: 20px 20px 20px 20px; |
There was a problem hiding this comment.
There is a short hand for this:
Suggested change
| padding: 20px 20px 20px 20px; | |
| padding: 20px; |
| flex-direction: column; | ||
| margin-top: 20px; | ||
| background-color: #fff; | ||
| padding: 20px 20px; |
There was a problem hiding this comment.
Suggested change
| padding: 20px 20px; | |
| padding: 20px; |
| display: flex; | ||
| flex-direction: column; | ||
| flex: 1 0 0; | ||
| margin-left: 30px; |
There was a problem hiding this comment.
Suggested change
| margin-left: 30px; | |
| margin: 0 30px; |
|
|
||
| <div> | ||
| <ul> | ||
| {teamMembers.map((member) => ( |
| }) => { | ||
| return ( | ||
| <li key={member.member_id}> | ||
| <div style={{ display: 'flex', alignItems: 'center' }}> |
There was a problem hiding this comment.
Please move this to a css class.
None of the companies are using this syntax, since inline css is very difficult to debug & mantain.
…ture-CPH/team26-checkin into frontend-navbar/meraj
ddobby94
approved these changes
Apr 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I pushed and merged my child's branch to this featured branch (after the edits/comments done). and all works correctly.
Fixes # (issue)
Demo
Checklist