Akif_NodeW1_Homework #350
Closed
Akif_NodeW1_Homework #350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eidosam
approved these changes
May 19, 2019
week1/homework/src/server.js
Outdated
| break; | ||
| default: | ||
| if (request.url === '' || request.url === '/') { | ||
| response.statusCode = 302; |
There was a problem hiding this comment.
Couple of issues here:
request.urlwill never be empty string, root is/.- Code
302refers to temporal redirection, which is not the case here. - Because there was explicit headers setting above (line 12), setting
response.statusCodewon't take an effect, see response.statusCode.
week1/homework/src/server.js
Outdated
| }); | ||
|
|
||
| return server; | ||
| } | ||
|
|
||
| module.exports = { | ||
| createServer | ||
| // eslint-disable-next-line comma-dangle |
There was a problem hiding this comment.
Better to fix linting errors/warnings instead of disabling Eslint rule[s].
There was a problem hiding this comment.
I know that but sometimes when I save the file, Eslint changes it incorrectly and even though I correct it by hand Eslint makes it incorrect. For instance, in the 'if-else' structure I write 'else' at the correct place but same problem. I don't know why.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.