Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Formating link #32

Closed
wants to merge 1 commit into from
Closed

Conversation

HelioCampos
Copy link

No description provided.

@martijnrusschen
Copy link
Member

This changes YouTube-nocookie to the normal YouTube site. Can you keep the same url?

@reedloden
Copy link
Contributor

Won't this break the embedded video on https://www.hacker101.com/sessions/introduction ?

@HelioCampos
Copy link
Author

HelioCampos commented Jan 31, 2018

The original URL breaks the formating if I put all the parameters. Does it need to have the curly braces and the variable? Can't you just add the final value to the variable in the URL?

@EdOverflow
Copy link
Contributor

@HelioCampos, this is actually the source code for https://www.hacker101.com. The content is really meant to be viewed there, hence the embedded YouTube videos.

@HelioCampos
Copy link
Author

I See. Will close the PR then. Regards,

@HelioCampos HelioCampos closed this Feb 1, 2018
@HelioCampos HelioCampos deleted the patch-1 branch February 1, 2018 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants