Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

onKeyDown function is not triggered in Month and Year Pickers. #4483

Closed
BoriskinaAnna opened this issue Jan 30, 2024 · 1 comment · Fixed by qburst/react-datepicker-3#14 or #4533
Closed

onKeyDown function is not triggered in Month and Year Pickers. #4483

BoriskinaAnna opened this issue Jan 30, 2024 · 1 comment · Fixed by qburst/react-datepicker-3#14 or #4533

Comments

@BoriskinaAnna
Copy link

Describe the bug
onKeyDown function is not triggered in Month and Year Pickers. It is triggered only in a day selection view.

Expected behavior
Function should be triggered in any view.

Desktop (please complete the following information):

  • OS: Windows 11
  • Browser Chrome
  • Version 120.0.6099.225
@balajis-qb
Copy link

Hi @martijnrusschen , Sorry! I wrongly mentioned this ticket in the PR instead of #4482. This issue is still open only, I'll raise a PR for it by tomorrow.

This was referenced Feb 26, 2024
Merged
Merged
balajis-qb pushed a commit to qburst/react-datepicker-3 that referenced this issue Feb 26, 2024
♻️ Update the test cases to use RTL based on the review comments
6b82aaf 
Hacker0x01#4533 (comment)
Closes: Hacker0x01#4483
martijnrusschen added a commit that referenced this issue Feb 26, 2024
@martijnrusschen
Merge pull request #4533 from qburst/issue-4483/fix/enable-onKeyDown-…
89249a5 
…for-month-year-pickers

Fix #4483: Enable onKeyDown handler for the month picker view and the year picker view
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@BoriskinaAnna @balajis-qb