Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When showQuarterYearPicker: true, minDate/maxDate doesn't always grey out arrows #4644

Closed
mikeCapozziICF opened this issue Mar 26, 2024 · 1 comment
Assignees

Comments

@mikeCapozziICF
Copy link

Describe the bug
A clear and concise description of what the bug is.
When I have a minDate and maxDate using Monthly or Yearly picker, these dates work correctly and my left and right arrows will grey out appropriately. However, if I use showQuarterYearPicker, I can have situations in which years above my maxDate and years below my MinDate still will show the black arrow and I can click and navigate to the "fully disabled" year where all quarters are greyed out and the user cannot select anything.

To Reproduce
Steps to reproduce the behavior:

Set showQuarterYearPicker=true and minDate 1/1/2023 and maxDate 12/31/2023. Now click on the input to show the datepicker and notice that you can click the backwards arrow, for example, to 2022 where all quarters are not selectable, leaving the user with nothing to do on that screen.

Expected behavior
A clear and concise description of what you expected to happen.
The expected behavior is that since there is no data in 2022, the arrow should either be hidden (or disabled if using showDisabledMonthNavigation). It should be consistent like the non-quarterly modes.

Screenshots
If applicable, add screenshots to help explain your problem.
image

Desktop (please complete the following information):

  • OS: iOS
  • Browser: chrome
  • Version: 123.0.6312.59

Additional context
n/a

@balajis-qb
Copy link

Hi @martijnrusschen , I'll work on this issue. Please assign it to me

balajis-qb pushed a commit to qburst/react-datepicker-3 that referenced this issue Apr 1, 2024
balajis-qb pushed a commit to qburst/react-datepicker-3 that referenced this issue Apr 1, 2024
martijnrusschen added a commit that referenced this issue Apr 1, 2024
…cker-navigation-button-visibility

Fix #4644: Handle the visibility of the previous and the next year navigation when showQuarterYearPicker is enabled
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants