Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move '}' for js code markdown. #1405

Merged
merged 1 commit into from
Jun 17, 2018

Conversation

kaekasui
Copy link
Contributor

It's fine, but I want to fix it.

before the change:

 <DatePicker selected={this.state.date}
  onSelect={this.handleSelect //when day is clicked}
  onChange={this.handleChange //only when value has changed}
 />

after the change:

 <DatePicker selected={this.state.date}
  onSelect={this.handleSelect} //when day is clicked
  onChange={this.handleChange} //only when value has changed
 />

@codecov
Copy link

codecov bot commented Jun 16, 2018

Codecov Report

Merging #1405 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1405   +/-   ##
=======================================
  Coverage   89.43%   89.43%           
=======================================
  Files          16       16           
  Lines        1070     1070           
  Branches      173      173           
=======================================
  Hits          957      957           
  Misses         20       20           
  Partials       93       93

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update febaf1d...8e07160. Read the comment docs.

@rafeememon rafeememon merged commit 8ab13e0 into Hacker0x01:master Jun 17, 2018
@kaekasui
Copy link
Contributor Author

thanks! I'll delete this branch.

@kaekasui kaekasui deleted the fix-commentout-position branch June 17, 2018 11:28
Squar89 pushed a commit to Squar89/react-datepicker2 that referenced this pull request Apr 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants