Fix for window undefined error in serverside rendering #1634
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1634 +/- ##
==========================================
- Coverage 89.76% 89.69% -0.08%
==========================================
Files 16 16
Lines 1114 1116 +2
Branches 194 194
==========================================
+ Hits 1000 1001 +1
- Misses 15 16 +1
Partials 99 99
Continue to review full report at Codecov.
|
|
Hi! When do you plan to merge this PR? It would be really useful to fix the SSR case with translations enabled. Thanks! |
| @@ -49,6 +49,10 @@ import isWithinInterval from "date-fns/isWithinInterval"; | |||
| import toDate from "date-fns/toDate"; | |||
| import parse from "date-fns/parse"; | |||
|
|
|||
| if (typeof window === 'undefined') { | |||
| global.window = {} | |||
There was a problem hiding this comment.
I think it would be much better to avoid modifying the global environment, and instead guard the problematic access to I think it would be best to abstract window with an undefined check.window away in the places where it's accessed to refer to either window or global(?). Adding a unit test for this would be great as well.
There was a problem hiding this comment.
yes, adding stuff to global is a no-go for libraries like that. ;-)
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Addresses #1619.