Add closeOnScroll prop #2209
Merged
Add closeOnScroll prop #2209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2209 +/- ##
==========================================
- Coverage 92.10% 92.09% -0.02%
==========================================
Files 20 20
Lines 1242 1252 +10
Branches 324 330 +6
==========================================
+ Hits 1144 1153 +9
Misses 40 40
- Partials 58 59 +1
Continue to review full report at Codecov.
|
|
If you can help me resolving the merge conflicts, we can get this one merged. |
p-rogas
pushed a commit
to p-rogas/react-datepicker
that referenced
this pull request
Mar 22, 2023
* Add closeOnScroll prop * add tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add closeOnScroll prop to enable. The prop accepts either a boolean or a function. If true, the datepicker will be closed when the document is scrolled. If function, then it executes the function to see whether the datepicker should be closed or not.