New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix class not applied on day component for datepicker with selectsRange
prop
#3595
Fix class not applied on day component for datepicker with selectsRange
prop
#3595
Conversation
- Apply the 'react-datepicker__day--selecting-range-end' class on the day component while user is selecting the end date for the range - Added unit test
selectsRange
propselectsRange
prop
Merging in the latest master branch should fix the CI checks on the Pull request. |
…selectsRange-datepicker
Good catch thanks :) |
Codecov Report
@@ Coverage Diff @@
## master #3595 +/- ##
=======================================
Coverage 93.32% 93.32%
=======================================
Files 20 20
Lines 1349 1349
Branches 375 375
=======================================
Hits 1259 1259
Misses 27 27
Partials 63 63
Continue to review full report at Codecov.
|
Hello, do you know when the new release will be available containing this PR please? Best regards, |
I'll try to get it released in the next few days |
Thanks :) |
Hello @martijnrusschen, I was wondering if it is possible to get a new release including this fix please :) |
@martijnrusschen any chance of a release of this, please? |
For now I'm working around this with |
…-while-selecting-end-for-selectsRange-datepicker
react-datepicker__day--selecting-range-end
class on the day component while user is selecting the end date for the rangeI observed that for datepicker having the
selectsRange
prop, when the user is selecting a range only thereact-datepicker__day--selecting-range-start
is set on the day component starting the range. While the user is moving the mouse on other day components, the classreact-datepicker__day--selecting-range-end
would not be applied on the hovered day to indicate that he is selecting that day as the end date.I would need this class to be applied to perform custom styling for achieving this kind of styling:
This would help me to not continue the blue line after the end date.