fix(months): monthClassName is passed the month instead of the current day #3709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3709 +/- ##
=======================================
Coverage 94.08% 94.08%
=======================================
Files 20 20
Lines 1723 1723
Branches 417 417
=======================================
Hits 1621 1621
Misses 31 31
Partials 71 71
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
p-rogas
pushed a commit
to p-rogas/react-datepicker
that referenced
this pull request
Mar 22, 2023
fix(months): monthClassName is passed the month instead of the current day
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to fix a bug with
monthClassNamein the month picker. The bug was that the current date with the selected year is passed for all months making the feature not be able to target specific months only all of them in a given year.The use case is something like this:
This might need some tests, however I don't exactly know where to add them. Given a bit of guidance I'm happy to contribute those as well.