Fixes #3723: Calendar does not jump back to today's date when using inline and Today button #3737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lected on clicking Today button
|
Can we add a test for this behaviour? |
Codecov Report
@@ Coverage Diff @@
## master #3737 +/- ##
==========================================
+ Coverage 93.34% 93.47% +0.12%
==========================================
Files 20 20
Lines 1352 1363 +11
Branches 377 381 +4
==========================================
+ Hits 1262 1274 +12
Misses 27 27
+ Partials 63 62 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
…e state when Today button is clicked after clicking any other date
|
Hello @martijnrusschen I have added the test for the fixed behaviour - here |
AthiraKadampatta
changed the title
|
@martijnrusschen Please review |
p-rogas
pushed a commit
to p-rogas/react-datepicker
that referenced
this pull request
Mar 22, 2023
…ay-click-behaviour Fixes Hacker0x01#3723: Calendar does not jump back to today's date when using inline and Today button
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3723
The
preSelectionvalue was not getting set to today's date on clicking Today button link.Because of this,
isKeyboardSelectedwas returning true and adding thereact-datepicker__day--keyboard-selectedclass to the already selected date. This resulted in the Today button not jumping to today's dateBefore the fix:
Before the fix.webm
After the fix:
After the fix.webm