Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Offset top crash fix 2 #3786

Merged
merged 2 commits into from Nov 22, 2022

Conversation

niktechnopro
Copy link

this PR fixes the crash that may occur on timezone change, when condition 'if (isBefore(time, activeTime) || isEqual(time, activeTime))' is false and 'this.centerLi' is undefined.

@codecov
Copy link

codecov bot commented Oct 5, 2022

Codecov Report

Merging #3786 (9f80bf0) into master (1d84d31) will increase coverage by 0.13%.
The diff coverage is 100.00%.

❗ Current head 9f80bf0 differs from pull request most recent head dc1931a. Consider uploading reports for the commit dc1931a to get more accurate results

@@            Coverage Diff             @@
##           master    #3786      +/-   ##
==========================================
+ Coverage   93.34%   93.47%   +0.13%     
==========================================
  Files          20       20              
  Lines        1352     1364      +12     
  Branches      377      382       +5     
==========================================
+ Hits         1262     1275      +13     
  Misses         27       27              
+ Partials       63       62       -1     
Impacted Files Coverage Δ
src/calendar.jsx 92.97% <100.00%> (+0.11%) ⬆️
src/month.jsx 95.00% <100.00%> (+1.19%) ⬆️
src/time.jsx 91.66% <100.00%> (+0.14%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants