Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update deps react-onclickoutside & react-popper #3793

Merged
merged 1 commit into from Oct 12, 2022

Conversation

Mudbill
Copy link
Contributor

@Mudbill Mudbill commented Oct 12, 2022

React 18 projects that use this package will get these warnings:

warning "react-datepicker > react-onclickoutside@6.12.1" has incorrect peer dependency "react@^15.5.x || ^16.x || ^17.x".
warning "react-datepicker > react-onclickoutside@6.12.1" has incorrect peer dependency "react-dom@^15.5.x || ^16.x || ^17.x".
warning "react-datepicker > react-popper@2.2.5" has incorrect peer dependency "react@^16.8.0 || ^17".

This PR updates the minor versions of react-onclickoutside and react-popper to stop these warnings. Both of these packages include React 18 in these versions.

Bumped react-popper 1 minor version.
v2.2.5 > v2.3.0

Support for React 18

Bumped react-onclickoutside 1 patch version:
v6.12.1 > v6.12.2
Couldn't find patch notes but commit reads that it only updated the peer deps.

Corrects peer dependencies complaining about lack of React 18 support
@codecov
Copy link

codecov bot commented Oct 12, 2022

Codecov Report

Merging #3793 (3000605) into master (e0f7b57) will decrease coverage by 0.07%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3793      +/-   ##
==========================================
- Coverage   93.54%   93.47%   -0.08%     
==========================================
  Files          20       20              
  Lines        1363     1363              
  Branches      381      381              
==========================================
- Hits         1275     1274       -1     
- Misses         26       27       +1     
  Partials       62       62              
Impacted Files Coverage Δ
src/year.jsx 92.30% <0.00%> (-1.93%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@martijnrusschen martijnrusschen merged commit 0bfd40c into Hacker0x01:master Oct 12, 2022
p-rogas pushed a commit to p-rogas/react-datepicker that referenced this pull request Mar 22, 2023
Update deps react-onclickoutside & react-popper
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants