Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix month and year picker disabled #3888

Merged
merged 5 commits into from Jan 9, 2023

Conversation

shu1007
Copy link
Contributor

@shu1007 shu1007 commented Jan 7, 2023

Nice to meet you. We have fixed some of the issues mentioned in the issue.(#2912 #3804 )

  • YearMonthPicker and yearPicker can now select the same month/year as the specified minDate and maxDate.
  • Some Unit test case added

@shu1007 shu1007 marked this pull request as ready for review January 7, 2023 03:33
@codecov
Copy link

codecov bot commented Jan 8, 2023

Codecov Report

Merging #3888 (25575b5) into master (31e35fc) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #3888      +/-   ##
==========================================
- Coverage   93.66%   93.63%   -0.03%     
==========================================
  Files          20       20              
  Lines        1373     1383      +10     
  Branches      383      388       +5     
==========================================
+ Hits         1286     1295       +9     
- Misses         25       26       +1     
  Partials       62       62              
Impacted Files Coverage Δ
src/date_utils.js 99.15% <100.00%> (+<0.01%) ⬆️
src/index.jsx 90.06% <100.00%> (+0.22%) ⬆️
src/month.jsx 95.04% <100.00%> (ø)
src/year.jsx 92.45% <100.00%> (-1.78%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@shu1007
Copy link
Contributor Author

shu1007 commented Jan 8, 2023

The code for which coverage is noted is not the one that has been corrected at this time.
https://app.codecov.io/gh/Hacker0x01/react-datepicker/pull/3888

Could you do a code review?

@martijnrusschen martijnrusschen merged commit 268d333 into Hacker0x01:master Jan 9, 2023
@martijnrusschen
Copy link
Member

Thanks for your fix and extensive tests on this subject

p-rogas pushed a commit to p-rogas/react-datepicker that referenced this pull request Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants