Upgrade date-fns to v3 #4481

ethanve · 2024-01-29T23:15:00Z

Upgrades date-fns to their latest version.

Changes that were needed:

All default exports were removed.
Intervals now normalize if the start date is after the end date

pullrequest

✅ This pull request was sent to the PullRequest network.

@ethanve you can click here to see the review status or cancel the code review job.

pullrequest

PullRequest Breakdown

Reviewable lines of change

+ 97
- 92

76% JavaScript
23% JavaScript (tests)
1% JSON

Generated lines of change

+ 5
- 7

Type of change

Feature - These changes are adding a new feature or improvement to existing code.

ethanve · 2024-01-29T23:17:41Z

test/date_utils_test.test.js

@@ -249,15 +249,15 @@ describe("date_utils", () => {
      ).toBe(true);
    });

-    it("should throw error if excluded date interval is invalid", () => {
+    it("should be enabled and normalize negative intervals correctly", () => {


See date-fns' release:

Functions that accept Interval arguments now do not throw an error if the start is before the end and handle it as a negative interval. If one of the properties in an Invalid Date, these functions also do not throw and handle them as invalid intervals.

👍

Frank T

pullrequest

While these are minor, I would recommend considering combining your imports now that you can match the style of your other imports. Beyond that I found no issues to prevent this from moving forward

James D

Reviewed with ❤️ by PullRequest

pullrequest · 2024-01-30T02:19:47Z

docs-site/src/components/Example/index.js

-import * as DateFNS from "date-fns/esm";
-import fi from "date-fns/locale/fi";
-import ptBR from "date-fns/locale/pt-BR";
-import enGB from "date-fns/locale/en-GB";


Given the new changes, I believe you can also combine this:

import { fi, ptBR, enGB } from "date-fns/locale";

🔹 Simplify Code (Nice to have)

James D

pullrequest · 2024-01-30T02:19:47Z

src/date_utils.js

-import toDate from "date-fns/toDate";
-import parse from "date-fns/parse";
-import parseISO from "date-fns/parseISO";
-import longFormatters from "date-fns/esm/_lib/format/longFormatters";


I believe these can be combined now too, which would make future updates like this smaller and easier:

import { isDate, isValid as isValidDate, // etc } from "date-fns"; [](#40d7fa71-0d7a-4e8b-bceb-bc2d8373eb84 "PullRequest Meta [Do Not Modify]") ###### 🔹 Simplify Code (Nice to have) ![Image of James D](https://static.pullrequest.com/avatars/reviewer_profiles/d88c81ac-6b7b-4d51-97f8-612312f23ba2?v=1b04Ew) **James D**

pullrequest

Pretty straightforward update. No merge blocking issues found. Thanks for the PR!

Frank T

Reviewed with ❤️ by PullRequest

martijnrusschen · 2024-01-30T07:05:29Z

This looks good, are there any breaking changes that require a major version bump of the package?

ethanve · 2024-01-31T18:41:58Z

@martijnrusschen I believe this should be a major version bump given the breaking changes in date-fns. This will not work with date-fns v2.

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [react-datepicker](https://togithub.com/Hacker0x01/react-datepicker) | [`^5.0.0` -> `^6.0.0`](https://renovatebot.com/diffs/npm/react-datepicker/5.1.0/6.0.0) | [![age](https://developer.mend.io/api/mc/badges/age/npm/react-datepicker/6.0.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/react-datepicker/6.0.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/react-datepicker/5.1.0/6.0.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/react-datepicker/5.1.0/6.0.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>Hacker0x01/react-datepicker (react-datepicker)</summary> ### [`v6.0.0`](https://togithub.com/Hacker0x01/react-datepicker/releases/tag/v6.0.0): 6.0.0 [Compare Source](https://togithub.com/Hacker0x01/react-datepicker/compare/v5.1.0...v6.0.0) #### What's Changed - Upgrade date-fns to v3 by [@ethanve](https://togithub.com/ethanve) in [Hacker0x01/react-datepicker#4481 - Switch workflows to Node 20 by [@martijnrusschen](https://togithub.com/martijnrusschen) in [Hacker0x01/react-datepicker#4490 #### New Contributors - [@ethanve](https://togithub.com/ethanve) made their first contribution in [Hacker0x01/react-datepicker#4481 **Full Changelog**: Hacker0x01/react-datepicker@v5.1.0...v6.0.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/toeverything/AFFiNE).

Upgrade date-fns to v3

68236d8

pullrequest bot reviewed Jan 29, 2024

View reviewed changes

ethanve commented Jan 29, 2024

View reviewed changes

pullrequest bot reviewed Jan 30, 2024

View reviewed changes

martijnrusschen merged commit ecf5d5e into Hacker0x01:main Jan 31, 2024
4 checks passed

ethanve deleted the feat/upgrade-date-fns branch January 31, 2024 18:42

BreakBB mentioned this pull request Feb 19, 2024

Fix Localization example in README.md #4523

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgrade date-fns to v3 #4481

Upgrade date-fns to v3 #4481

ethanve commented Jan 29, 2024 •

edited

pullrequest bot left a comment

pullrequest bot left a comment

ethanve Jan 29, 2024

pullrequest bot Jan 30, 2024

pullrequest bot left a comment

pullrequest bot Jan 30, 2024

pullrequest bot Jan 30, 2024

pullrequest bot left a comment

martijnrusschen commented Jan 30, 2024

ethanve commented Jan 31, 2024

Upgrade date-fns to v3 #4481

Upgrade date-fns to v3 #4481

Conversation

ethanve commented Jan 29, 2024 • edited

pullrequest bot left a comment

Choose a reason for hiding this comment

pullrequest bot left a comment

Choose a reason for hiding this comment

PullRequest Breakdown

ethanve Jan 29, 2024

Choose a reason for hiding this comment

pullrequest bot Jan 30, 2024

Choose a reason for hiding this comment

pullrequest bot left a comment

Choose a reason for hiding this comment

pullrequest bot Jan 30, 2024

Choose a reason for hiding this comment

🔹 Simplify Code (Nice to have)

pullrequest bot Jan 30, 2024

Choose a reason for hiding this comment

pullrequest bot left a comment

Choose a reason for hiding this comment

martijnrusschen commented Jan 30, 2024

ethanve commented Jan 31, 2024

ethanve commented Jan 29, 2024 •

edited