feat : add usePointerEvent props #4553

yuki0410-dev · 2024-03-01T10:37:41Z

I want to fix a bug I reported in a previous PR,
Inspired by the comments in the previous PR, we have modified the policy to allow users to freely choose by Props.

pullrequest

✅ This pull request was sent to the PullRequest network.

@yuki0410-dev you can click here to see the review status or cancel the code review job.

pullrequest

PullRequest Breakdown

Reviewable lines of change

+ 178
- 55

85% JavaScript (tests)
14% JavaScript
1% Markdown

Type of change

Feature - These changes are adding a new feature or improvement to existing code.

codecov · 2024-03-01T10:39:04Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.65%. Comparing base (6852294) to head (046c42d).

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #4553      +/-   ##
==========================================
+ Coverage   95.52%   95.65%   +0.13%     
==========================================
  Files          29       29              
  Lines        2569     2579      +10     
  Branches     1055     1069      +14     
==========================================
+ Hits         2454     2467      +13     
+ Misses        115      112       -3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

yuki0410-dev · 2024-03-01T10:39:07Z

test/week_test.test.js

    let dayMouseEntered = null;

    function onDayMouseEnter(day) {
      dayMouseEntered = day;
    }

    const weekStart = utils.newDate();
-    const week = shallow(
+    const week = mount(


Shallow was changed to mount because simulate("pointerenter") could not be fired correctly

Thanks, that's great to know. It might actually be worth adding that as a comment inline above this line.

Ryan

I have added a comment.

That looks great and makes a big difference. Thank you!

Ryan

pullrequest

This is mostly adding a flag for if mouse is available and adding tests accordingly. Looks good!

Simon

Reviewed with ❤️ by PullRequest

pullrequest

This is looking really good. Thanks for taking the feedback and submitting this new PR. It's also very appreciated that you took the time to add tests. I just had a few minor comments below.

Nice work!

Ryan

Reviewed with ❤️ by PullRequest

pullrequest · 2024-03-01T19:20:59Z

docs/index.md

@@ -160,3 +160,4 @@
 | `wrapperClassName`              | `string`                       |                            |             |
 | `yearDropdownItemNumber`        | `number`                       |                            |             |
 | `yearItemNumber`                | `number`                       | `DEFAULT_YEAR_ITEM_NUMBER` |             |
+| `usePointerEvent`               | `bool`                         | `false`                    |             |


It could be useful to add a brief note about what usePointerEvent does and when to use it.

🔹 Improve Readability (Nice to have)

Ryan

Added description to docs/datepicker.md, since the description of other Props was also written there.

Yep, that's my mistake, I meant to make that comment on that file instead. Thanks!

Ryan

pullrequest · 2024-03-01T19:20:59Z

test/day_test.test.js

@@ -932,6 +932,27 @@ describe("Day", () => {
    });
  });

+  describe("pointer enter", () => {
+    var onMouseEnterCalled;


As more tests are added in this describe block over time, it feels like this could get a bit harder to maintain. Is there any reason to not just define these per-test as needed?

🔹 Best Practices (Nice to have)

Ryan

I had added a test for Pointer Event in parallel with mouse Event as well as others,
I removed the describe section and added an it section, is this correct?

Yes I think that looks good.

Ryan

yuki0410-dev · 2024-03-01T23:36:33Z

Thank you for your review.
We have made corrections in response to your comments.

yuki0410-dev · 2024-03-02T17:41:44Z

I have closed my previous PR.

Is there anything else I can do to get this PR merged?

pullrequest

I have closed my previous PR.

Is there anything else I can do to get this PR merged?

Thanks for all of your hard work and adjustments to the feedback @yuki0410-dev. We just have to wait for one of the maintainers to approve and merge this.

Ryan

martijnrusschen

These changes look good, however the use of Enzyme is deprecated and I'd rather not introduce more test using Enzyme. Can you switch the test cases to React Testing Library?

yuki0410-dev · 2024-03-04T02:40:34Z

@martijnrusschen
Thanks for your advice.
I have tried to replace enzyme to RTL as best I can, what do you think?

pullrequest

PullRequest reviewed the updates made to #4553 up until the latest commit (046c42d). No further issues were found.

Reviewed by:

Ryan

pullrequest bot reviewed Mar 1, 2024

View reviewed changes

yuki0410-dev commented Mar 1, 2024

View reviewed changes

pullrequest bot reviewed Mar 1, 2024

View reviewed changes

yuki0410-dev force-pushed the feat/usePointerEvent branch from 685f0be to a42054a Compare March 1, 2024 23:29

yuki0410-dev mentioned this pull request Mar 2, 2024

fix: Change onMouseXXX event to onPointerXXX event #4542

Closed

pullrequest bot reviewed Mar 2, 2024

View reviewed changes

martijnrusschen reviewed Mar 3, 2024

View reviewed changes

yuki0410-dev added 2 commits March 4, 2024 11:36

feat : add usePointerEvent props

a419d08

fix tests (enzyme to RTL)

046c42d

yuki0410-dev force-pushed the feat/usePointerEvent branch from 6ce60d4 to 046c42d Compare March 4, 2024 02:36

yuki0410-dev requested a review from martijnrusschen March 4, 2024 14:17

pullrequest bot reviewed Mar 4, 2024

View reviewed changes

martijnrusschen merged commit 42d88b8 into Hacker0x01:main Mar 4, 2024
6 checks passed

yuki0410-dev deleted the feat/usePointerEvent branch March 5, 2024 06:36

pullrequest bot mentioned this pull request Mar 5, 2024

Add Enzyme deprecation linter #4563

Closed

yuki0410-dev mentioned this pull request Mar 10, 2024

feat: run prettier check in ci #4575

Merged

pullrequest bot mentioned this pull request Mar 14, 2024

add types #4592

Closed

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat : add usePointerEvent props #4553

feat : add usePointerEvent props #4553

yuki0410-dev commented Mar 1, 2024

pullrequest bot left a comment

pullrequest bot left a comment •

edited

codecov bot commented Mar 1, 2024 •

edited

yuki0410-dev Mar 1, 2024

pullrequest bot Mar 1, 2024

yuki0410-dev Mar 1, 2024

pullrequest bot Mar 2, 2024

pullrequest bot left a comment

pullrequest bot left a comment

pullrequest bot Mar 1, 2024

yuki0410-dev Mar 1, 2024

pullrequest bot Mar 2, 2024

pullrequest bot Mar 1, 2024

yuki0410-dev Mar 1, 2024

pullrequest bot Mar 2, 2024

yuki0410-dev commented Mar 1, 2024

yuki0410-dev commented Mar 2, 2024

pullrequest bot left a comment

martijnrusschen left a comment

yuki0410-dev commented Mar 4, 2024

pullrequest bot left a comment

feat : add usePointerEvent props #4553

feat : add usePointerEvent props #4553

Conversation

yuki0410-dev commented Mar 1, 2024

pullrequest bot left a comment

Choose a reason for hiding this comment

pullrequest bot left a comment • edited

Choose a reason for hiding this comment

PullRequest Breakdown

codecov bot commented Mar 1, 2024 • edited

Codecov Report

yuki0410-dev Mar 1, 2024

Choose a reason for hiding this comment

pullrequest bot Mar 1, 2024

Choose a reason for hiding this comment

yuki0410-dev Mar 1, 2024

Choose a reason for hiding this comment

pullrequest bot Mar 2, 2024

Choose a reason for hiding this comment

pullrequest bot left a comment

Choose a reason for hiding this comment

pullrequest bot left a comment

Choose a reason for hiding this comment

pullrequest bot Mar 1, 2024

Choose a reason for hiding this comment

🔹 Improve Readability (Nice to have)

yuki0410-dev Mar 1, 2024

Choose a reason for hiding this comment

pullrequest bot Mar 2, 2024

Choose a reason for hiding this comment

pullrequest bot Mar 1, 2024

Choose a reason for hiding this comment

🔹 Best Practices (Nice to have)

yuki0410-dev Mar 1, 2024

Choose a reason for hiding this comment

pullrequest bot Mar 2, 2024

Choose a reason for hiding this comment

yuki0410-dev commented Mar 1, 2024

yuki0410-dev commented Mar 2, 2024

pullrequest bot left a comment

Choose a reason for hiding this comment

martijnrusschen left a comment

Choose a reason for hiding this comment

yuki0410-dev commented Mar 4, 2024

pullrequest bot left a comment

Choose a reason for hiding this comment

pullrequest bot left a comment •

edited

codecov bot commented Mar 1, 2024 •

edited