Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support second-level granularity to injectTimes #4683

Merged
merged 6 commits into from
Apr 14, 2024

Conversation

yykcool
Copy link
Contributor

@yykcool yykcool commented Apr 12, 2024

Description

Linked issue: None

Problem
seconds from Datetime objects passed into injectTime setting is currently ignored by the date picker

Changes
added support for seconds, changed doc-site example to reflect it, and added 1 test as well.

also corrected timeIntervals to intervals on existing tests found in inject_times_test.test.js to account for the fact that timeIntervals does not exist as a parameter, and the correct one should be intervals instead

Contribution checklist

  • I have followed the contributing guidelines.
  • I have added sufficient test coverage for my changes.
  • I have formatted my code with Prettier and checked for linting issues with ESLint for code readability.

Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ This pull request was sent to the PullRequest network for review. Expert reviewers are now being matched to your request based on the code's requirements. Stay tuned!

What to expect from this code review:
  • Comments posted to any areas of potential concern or improvement.
  • Detailed feedback or actions needed to resolve issues that are found.
  • Turnaround times vary, but we aim to be swift.

@yykcool you can click here to see the review status or cancel the code review job.

Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PullRequest Breakdown

Reviewable lines of change

+ 54
- 11

51% JavaScript (tests)
48% JavaScript
2% Other

Type of change

Feature - These changes are adding a new feature or improvement to existing code.

Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change looks good - no major issues that I could find.

Image of Jacques Jacques


Reviewed with ❤️ by PullRequest

Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR looks good to me overall for adding support for seconds. I had two comments for minor adjustments that need to be made below, but overall I didn't notice any major issues here.

Thanks for taking care of this!

Image of Ryan Ryan


Reviewed with ❤️ by PullRequest

test/inject_times_test.test.js Show resolved Hide resolved
test/inject_times_test.test.js Outdated Show resolved Hide resolved
test/inject_times_test.test.js Outdated Show resolved Hide resolved
Copy link
Member

@martijnrusschen martijnrusschen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the test case comments

@yykcool
Copy link
Contributor Author

yykcool commented Apr 14, 2024

comments are addressed

@martijnrusschen
Copy link
Member

Can you make sure to merge with the latest main branch to upload the code coverage file?

@yykcool
Copy link
Contributor Author

yykcool commented Apr 14, 2024

it seems like things are already up to date (tried to do a merge from the main branch), is there anything i might have missed?

@martijnrusschen
Copy link
Member

can you try again?

@yykcool
Copy link
Contributor Author

yykcool commented Apr 14, 2024

done

Copy link

codecov bot commented Apr 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.00%. Comparing base (f81afc4) to head (8ae5a60).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4683   +/-   ##
=======================================
  Coverage   97.00%   97.00%           
=======================================
  Files          28       28           
  Lines        2635     2638    +3     
  Branches     1133     1116   -17     
=======================================
+ Hits         2556     2559    +3     
  Misses         79       79           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants