-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix keyboard keydown event handler #4742
Fix keyboard keydown event handler #4742
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ This pull request was sent to the PullRequest network for review. Expert reviewers are now being matched to your request based on the code's requirements. Stay tuned!
What to expect from this code review:
- Comments posted to any areas of potential concern or improvement.
- Detailed feedback or actions needed to resolve issues that are found.
- Turnaround times vary, but we aim to be swift.
@alvaromartinez986 you can click here to see the review status or cancel the code review job.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PullRequest Breakdown
Reviewable lines of change
+ 14
- 2
69% JavaScript (tests)
31% JavaScript
Type of change
Fix - These changes are likely to be fixing a bug or issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change looks good and matches the description regarding fixing the keydown handler when showTimeSelectOnly
is true
Reviewed with ❤️ by PullRequest
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4742 +/- ##
=======================================
Coverage 97.26% 97.26%
=======================================
Files 11 11
Lines 1461 1464 +3
Branches 651 654 +3
=======================================
+ Hits 1421 1424 +3
Misses 40 40 ☔ View full report in Codecov by Sentry. |
name: Pull Request
about: Create a pull request to improve this repository
title: "Keyboard fix for time picker show time select only"
labels: ""
assignees: "alvaromartinez986"
Description
Linked issue: #4701
Problem
Keyboard not working when showTimeSelectOnly is True
Changes
Add the selector for the time container when the prop showTimeSelectOnly is true
Screenshots
To reviewers
Contribution checklist