-
Notifications
You must be signed in to change notification settings - Fork 10
Add Loggable #281
Add Loggable #281
Conversation
1aa08df
to
e5b0d4d
Compare
9c22481
to
0f86140
Compare
Reviewed 23 of 24 files at r1, 4 of 4 files at r2. lib/log/model/loggable/flow.ex, line 154 at r2 (raw file):
Move the test/log/event/handler/log_test.exs, line 24 at r2 (raw file):
Review this, I think it's on another scope / already tested Comments from Reviewable |
Reviewed 53 of 54 files at r3. Comments from Reviewable |
Ebert has finished reviewing this Pull Request and has found:
You can see more details about this review at https://ebertapp.io/github/HackerExperience/Helix/pulls/281. |
Reviewed 1 of 1 files at r4. Comments from Reviewable |
Depends on #271
Closes #278
TODO:
all_events
(cf Add 'all_events' catch-all to HELF.Event HELF#26)Incidental:
inserted_at
tocreation_time
This change is![Reviewable](https://camo.githubusercontent.com/23b05f5fb48215c989e92cc44cf6512512d083132bd3daf689867c8d9d386888/68747470733a2f2f72657669657761626c652e696f2f7265766965775f627574746f6e2e737667)