Skip to content
This repository has been archived by the owner on Jun 11, 2023. It is now read-only.

Add Helix.Software macro #298

Merged
merged 2 commits into from
Oct 12, 2017
Merged

Add Helix.Software macro #298

merged 2 commits into from
Oct 12, 2017

Conversation

renatomassaro
Copy link
Member

@renatomassaro renatomassaro commented Oct 11, 2017 •
edited
Loading

  • Helix.Software macro
  • Software definition at Helix.Software.Model.Software
  • Refactor FileModule into File.Module

Incidental:

  • Renamed software_type to type on the "software_types" table

This change is Reviewable

@renatomassaro renatomassaro self-assigned this Oct 11, 2017
@sourcelevel-bot
Copy link

Ebert has finished reviewing this Pull Request and has found:

  • 1 possible new issue (including those that may have been commented here).
  • 2 fixed issues! 🎉

You can see more details about this review at https://ebertapp.io/github/HackerExperience/Helix/pulls/298.

@renatomassaro
Copy link
Member Author

Reviewed 13 of 13 files at r1.
Review status: all files reviewed at latest revision, 1 unresolved discussion.

lib/software/model/file.ex, line 13 at r1 (raw file):

  alias Helix.Software.Model.Software
  alias Helix.Software.Model.Storage
  alias __MODULE__, as: File

Because why not? 😂

Comments from Reviewable

@renatomassaro renatomassaro merged commit 69e70ac into HackerExperience:master Oct 12, 2017
@renatomassaro renatomassaro deleted the software-macro branch October 12, 2017 01:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@renatomassaro renatomassaro

Labels
Kind:Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@renatomassaro