Public FTP

[renatomassaro]

• Model
• Internal
• Action/Query
• Events. Postponed. See Implement events of PublicFTP #302
• Henforcer
• Public
• Driver
• Add list of public files on DNS response (Implement public files in DNS response #300)
• pftp.file.download request
• Censor PFTPDownload logs
• Censor PFTPDownload connection. Postponed. See Add Network.Index #304

TODO:

• Server param/identifier must be a nip, not the Server.id
• Test StorageQuery.get_main_storage
• Be awesome

---

Incidental:

• Improvements on Helix.Henforcer
• Improvements on existing Henforcers
• Improvements on Hector
• EntityHenforcer
• Helix.Websocket.Request macro
• Refactor all WebsocketRequests to use the less-boilerplaty interface
• Helix.Websocket.Channel macro
• Refactor all WebsocketChannels to use the less-boilerplaty interface
• Moved requests into their own services

---

This change is 

[renatomassaro]

Reviewed 87 of 92 files at r1, 11 of 11 files at r2.
Review status: all files reviewed at latest revision, 8 unresolved discussions.

---

lib/entity/henforcer/entity.ex, line 31 at r2 (raw file):

  @type owns_server_relay :: %{entity: Entity.t, server: Server.t}
  @type owns_server_relay_partial :: owns_server_relay

extra line

---

lib/event/loggable/utils.ex, line 19 at r2 (raw file):

  @unknown_ip "Unknown"

  def format_ip(ip),

This method is private

---

lib/event/loggable/utils.ex, line 81 at r2 (raw file):

  """
  defp char_is_number?(char),
    # do: char in [48, 49, 50, 51, 52, 53, 54, 55, 56, 57]

rm

---

lib/hell/hell/hector.ex, line 325 at r2 (raw file):

    Enum.map(result.rows, fn row ->
      if :erlang.function_exported(module, :hector_loader, 2) do

Document this feature

---

lib/hell/hell/utils.ex, line 60 at r2 (raw file):

    do: concat(a, b) |> concat(c)

  def atom_contains?(a, value) when is_atom(a) do

docme

---

lib/software/public/file.ex, line 59 at r2 (raw file):

  end

  def pftp_download(network_id, gateway_id, pftp, storage, file) do

rm me

---

lib/software/public/file.ex, line 71 at r2 (raw file):

  end

  # def pftp_add_file(pftp = %PublicFTP{}, file = %File{}) do

rm me

---

test/support/channel/request/macros.ex, line 11 at r2 (raw file):

    end
  end

rm

---

Comments from Reviewable

[sourcelevel-bot]

Ebert has finished reviewing this Pull Request and has found:

• 3 possible new issues (including those that may have been commented here).
• 6 fixed issues! 🎉

You can see more details about this review at https://ebertapp.io/github/HackerExperience/Helix/pulls/301.

[renatomassaro]

Reviewed 6 of 6 files at r3.
Review status: all files reviewed at latest revision, all discussions resolved.

---

Comments from Reviewable