-
Notifications
You must be signed in to change notification settings - Fork 10
Conversation
057c1a2
to
f14622a
Compare
Ebert has finished reviewing this Pull Request and has found:
You can see more details about this review at https://ebertapp.io/github/HackerExperience/Helix/pulls/378. |
Reviewed 111 of 123 files at r1, 12 of 12 files at r2. lib/event/utils.ex, line 7 at r2 (raw file):
spec + docs lib/event/loggable/flow.ex, line 85 at r2 (raw file):
explain better how this works lib/event/loggable/flow.ex, line 320 at r2 (raw file):
doc + spec (til the end of the file) lib/software/websocket/requests/cracker/bruteforce.ex, line 82 at r2 (raw file):
Review πββοΈ lib/universe/bank/action/flow/bank_account.ex, line 43 at r2 (raw file):
it's not Comments from Reviewable |
Reviewed 4 of 4 files at r3. Comments from Reviewable |
Closes #380. Closes #369. Closes #256.
π§ π·ββοΈ ποΈ π₯
Net
NetworkHenforcer.Bounce
(inventory?)TODO:
network_id
onServerPublic.connect_to_server/3
Incidental
NetworkFactory
πdestination_id
totarget_id
on Tunnelclient_nip
toHETypes
, as well asto_nip
conversion method onClientUtils
Helix.Client.Renderer
system (later onClientUtils
could be moved toHelix.Client
)TunnelFlow
assert_bounce
macro helper.[1] - They are, implicitly. AnyMap would call
connections_through_node
. Ifserver_id
is not the Tunnel'sgateway_id
ortarget_id
, then it always is a bounce. In that case, display connection (link) as bounce from (n-1) to (n+1) of typeconnection_type
.This change isβ