Skip to content
This repository has been archived by the owner on Jun 11, 2023. It is now read-only.

Return Database.Virus information on DatabaseIndex #395

Merged
merged 6 commits into from
Mar 11, 2018

Conversation

renatomassaro
Copy link
Member

@renatomassaro renatomassaro commented Mar 10, 2018

Now the virus information is returned on the DatabaseIndex, during the AccountBootstrap process. This should be enough for the Client to properly render virus information on the HackedDatabase and VirusPanel apps.

Incidental

  • Refactored DatabaseServer and DatabaseBankAccount to submodules (Database.Server and Database.BankAccount)
  • (Attempt to) Fix VirusCollect-related tests failing on slow systems (travis)

This change is Reviewable

@sourcelevel-bot
Copy link

Ebert has finished reviewing this Pull Request and has found:

  • 1 possible new issue (including those that may have been commented here).

You can see more details about this review at https://ebertapp.io/github/HackerExperience/Helix/pulls/395.

@renatomassaro
Copy link
Member Author

Reviewed 26 of 26 files at r1, 3 of 3 files at r2.
Review status: all files reviewed at latest revision, 2 unresolved discussions.


lib/entity/model/database/server.ex, line 142 at r2 (raw file):

      do: where(query, [d], d.server_id == ^id)

    def join_database_viruses(query) do

Spec


lib/entity/public/index/database.ex, line 128 at r2 (raw file):

  end

  defp render_virus(entry = %Database.Virus{}, entity_viruses) do

spec


Comments from Reviewable

@renatomassaro
Copy link
Member Author

Reviewed 1 of 26 files at r1, 2 of 2 files at r3.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@renatomassaro renatomassaro merged commit 862f284 into HackerExperience:master Mar 11, 2018
@renatomassaro renatomassaro deleted the db-virus branch March 11, 2018 03:02
themaxhero pushed a commit to themaxhero/Helix that referenced this pull request Mar 29, 2018
Return Database.Virus information on DatabaseIndex
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant