This repository has been archived by the owner on Jun 11, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 10
Return Database.Virus information on DatabaseIndex #395
Merged
renatomassaro
merged 6 commits into
HackerExperience:master
from
renatomassaro:db-virus
Mar 11, 2018
Merged
Return Database.Virus information on DatabaseIndex #395
renatomassaro
merged 6 commits into
HackerExperience:master
from
renatomassaro:db-virus
Mar 11, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ebert has finished reviewing this Pull Request and has found:
You can see more details about this review at https://ebertapp.io/github/HackerExperience/Helix/pulls/395. |
Reviewed 26 of 26 files at r1, 3 of 3 files at r2. lib/entity/model/database/server.ex, line 142 at r2 (raw file):
Spec lib/entity/public/index/database.ex, line 128 at r2 (raw file):
spec Comments from Reviewable |
Reviewed 1 of 26 files at r1, 2 of 2 files at r3. Comments from Reviewable |
themaxhero
pushed a commit
to themaxhero/Helix
that referenced
this pull request
Mar 29, 2018
Return Database.Virus information on DatabaseIndex
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now the virus information is returned on the DatabaseIndex, during the AccountBootstrap process. This should be enough for the Client to properly render virus information on the
HackedDatabase
andVirusPanel
apps.Incidental
DatabaseServer
andDatabaseBankAccount
to submodules (Database.Server
andDatabase.BankAccount
)This change is