Skip to content
This repository has been archived by the owner on Jun 11, 2023. It is now read-only.

Implement Bank system #399

Open
wants to merge 32 commits into
base: master
Choose a base branch
from

Conversation

themaxhero
Copy link
Member

@themaxhero themaxhero commented Apr 6, 2018

Implement bank channel and related requests and events

Progress:

  • Implement bank channel
  • Create BankAccount Request
  • Transfer Request
  • Change password Request
  • Convert token into password Request
  • Close BankAccount Request
  • BankAccount bootstrap Request
  • Logout from BankAccount Request
  • BankAccountUpdated Event
  • BankAccountRemoved Event
  • HackedBankAccountAcquired Event
  • HackedBankAccountUpdated Event
  • HackedBankAccountRemoved Event
  • BankTransferSuccessful Event
  • BankTransferFailed Event
  • BankAccountLoggedIn Event
  • BankAccountLoggedOut Event

This change is Reviewable

Marcelo Amancio de Lima Santos added 2 commits April 6, 2018 16:00
@sourcelevel-bot
Copy link

Hello, @themaxhero! This is your first Pull Request that will be reviewed by Ebert, an automatic Code Review service. It will leave comments on this diff with potential issues and style violations found in the code as you push new commits. You can also see all the issues found on this Pull Request on its review page. Please check our documentation for more information.

@themaxhero themaxhero force-pushed the implement-back-channel branch 7 times, most recently from e583741 to 5e8fcf4 Compare April 19, 2018 20:38
@themaxhero themaxhero force-pushed the implement-back-channel branch 2 times, most recently from ba99ad8 to 89a45e5 Compare April 25, 2018 20:33
@themaxhero themaxhero force-pushed the implement-back-channel branch 3 times, most recently from 87fc355 to d8a2a73 Compare May 2, 2018 20:48
@themaxhero themaxhero force-pushed the implement-back-channel branch 2 times, most recently from 8cebfb0 to 8e203a1 Compare May 4, 2018 23:17
@sourcelevel-bot
Copy link

Ebert has finished reviewing this Pull Request and has found:

  • 11 possible new issues (including those that may have been commented here).
  • 3 fixed issues! 🎉

But beware that this branch is 31 commits behind the HackerExperience:master branch, and a review of an up to date branch would produce more accurate results.

You can see more details about this review at https://ebertapp.io/github/HackerExperience/Helix/pulls/399.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant