This repository has been archived by the owner on Jun 11, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 10
Implement Bank system #399
Open
themaxhero
wants to merge
32
commits into
HackerExperience:master
Choose a base branch
from
themaxhero:implement-back-channel
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Implement Bank system #399
themaxhero
wants to merge
32
commits into
HackerExperience:master
from
themaxhero:implement-back-channel
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hello, @themaxhero! This is your first Pull Request that will be reviewed by Ebert, an automatic Code Review service. It will leave comments on this diff with potential issues and style violations found in the code as you push new commits. You can also see all the issues found on this Pull Request on its review page. Please check our documentation for more information. |
e583741
to
5e8fcf4
Compare
ba99ad8
to
89a45e5
Compare
87fc355
to
d8a2a73
Compare
8cebfb0
to
8e203a1
Compare
8e203a1
to
aa2a755
Compare
60c8c28
to
12e6b62
Compare
This was referenced May 30, 2018
12e6b62
to
1a6bd56
Compare
7962580
to
b70c5a1
Compare
b07c676
to
1a2e58e
Compare
2f2f20a
to
30427e5
Compare
00ab32b
to
23580b0
Compare
23580b0
to
c160c2f
Compare
Ebert has finished reviewing this Pull Request and has found:
But beware that this branch is 31 commits behind the You can see more details about this review at https://ebertapp.io/github/HackerExperience/Helix/pulls/399. |
c160c2f
to
e6d301d
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement bank channel and related requests and events
Progress:
BankAccount
RequestBankAccount
RequestBankAccount
bootstrap RequestBankAccount
RequestThis change is![Reviewable](https://camo.githubusercontent.com/23b05f5fb48215c989e92cc44cf6512512d083132bd3daf689867c8d9d386888/68747470733a2f2f72657669657761626c652e696f2f7265766965775f627574746f6e2e737667)