Skip to content
This repository has been archived by the owner on Jun 11, 2023. It is now read-only.

Add new Helix.ID format #408

Merged
merged 5 commits into from
Jul 4, 2018

Conversation

renatomassaro
Copy link
Member

@renatomassaro renatomassaro commented Jul 2, 2018

Depends on #406. Closes #377.

Documentation at #377 and lib/id/id.ex.


This change is Reviewable

@sourcelevel-bot
Copy link

Ebert has finished reviewing this Pull Request and has found:

  • 2 possible new issues (including those that may have been commented here).
  • 1 fixed issue! 🎉

You can see more details about this review at https://ebertapp.io/github/HackerExperience/Helix/pulls/408.

@renatomassaro
Copy link
Member Author

Reviewed 141 of 141 files at r1.
Review status: :shipit: complete! all files reviewed, all discussions resolved


lib/hell/hell/ecto_macros.ex, line 43 at r1 (raw file):

  end

  defmacro cast_pk(changeset, field, pk) do

doc


lib/hell/hell/ecto_macros.ex, line 49 at r1 (raw file):

  end

  defmacro put_pk(changeset, heritage, domain, opts \\ unquote([])) do

doc


lib/hell/hell/id.ex, line 78 at r1 (raw file):

          do: :error

        def generate do

remove generate/0


lib/hell/hell/id.ex, line 82 at r1 (raw file):

        end

        def generate(domain) when is_tuple(domain) or is_atom(domain),

@doc false


lib/hell/hell/id.ex, line 87 at r1 (raw file):

          do: %__MODULE__{id: Helix.ID.generate(heritage, domain)}

        def get_field,

@doc false


Comments from Reviewable

@renatomassaro
Copy link
Member Author

Reviewed 4 of 4 files at r2.
Review status: :shipit: complete! all files reviewed, all discussions resolved


Comments from Reviewable

@renatomassaro renatomassaro merged commit ad321e6 into HackerExperience:master Jul 4, 2018
@renatomassaro renatomassaro deleted the helix-id branch July 4, 2018 04:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant