Skip to content
This repository has been archived by the owner on Jun 22, 2024. It is now read-only.

[FEATURE] Prepare for first release #49

Merged
merged 26 commits into from
Jan 6, 2021
Merged

[FEATURE] Prepare for first release #49

merged 26 commits into from
Jan 6, 2021

Conversation

roysti10
Copy link
Member

@roysti10 roysti10 commented Dec 29, 2020

Description

  • The index.html page has been made dynamic using the pycricbuzz package

  • A New and updated crawler has been setup

  • Prediction works with a few minor bugs (will be fixed soon)

  • Cleaned frontend of the repo

  • Dockerfiles made

Tick the appropriate choice (Delete the rest):

  • Bug Fix (Non- Breaking)
  • Breaking Fix
  • New Feature (Breaking)
  • Web Scraping / Automation

* The index.html page has been made dynamic using the pycricbuzz package
pls follow this is a breaking change , the prediction wont work just yet

* [LICENSE] Added License doc strings as suggested by AGPLv3 License
@roysti10 roysti10 force-pushed the feature-final branch 2 times, most recently from 7d64a9d to f0dd2be Compare January 3, 2021 16:49
roysti10 and others added 3 commits January 5, 2021 15:09
* dockerfiles

Co-authored-by: Bastian <scientes12@gmail.com>
Co-authored-by: Daniel <54536136+DAN-329@users.noreply.github.com>
@roysti10 roysti10 changed the title [WIP][FEATURE] Prepare for first release [FEATURE] Prepare for first release Jan 5, 2021
rm -rf /var/lib/apt/lists/*
COPY ./requirements.txt /app/requirements.txt
RUN pip install --no-cache-dir --user -r /app/requirements.txt; rm -r /tmp

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you really need a separate compile image? It seems that you are just copying the installed dependencies over

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think not,
I can probably use the one already referenced intially

COPY ./app /app/app
COPY ./crawler /app/crawler
COPY ./scrapy.cfg /app/scrapy.cfg
ENV PYTHONPATH=/app
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what's going on here with the pythonpath. Just changing WORKDIR to app should add the necessary modules to pythonpath

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right

app/fantasy_cricket/__init__.py Show resolved Hide resolved
app/fantasy_cricket/team.py Outdated Show resolved Hide resolved
app/main.py Outdated Show resolved Hide resolved
requirements.txt Outdated Show resolved Hide resolved
@roysti10 roysti10 merged commit 34bde0f into master Jan 6, 2021
Web Scraping / Automation automation moved this from In progress to Done Jan 6, 2021
roysti10 added a commit that referenced this pull request Jan 7, 2021
* [FEATURE] Made the page dynamic

* [LICENSE] Added License doc strings as suggested by AGPLv3 License

* predicts score

* crawler complete

* Website and crawler integrated

* SEO tags

* Cleaned query params(#57)

* Dockerfiles set up(#59)

* Improved UI

Co-authored-by: Shreyas Raviprasad <shreyasraviprasad457@gmail.com>
Co-authored-by: Sammith S Bharadwaj <54738235+SammithSB@users.noreply.github.com>
Co-authored-by: scientes <34819304+scientes@users.noreply.github.com>
Co-authored-by: Bastian <scientes12@gmail.com>
Co-authored-by: Daniel <54536136+DAN-329@users.noreply.github.com>
Co-authored-by: SammithSB <sammithsb@gmail.com>
roysti10 added a commit that referenced this pull request Jan 7, 2021
* [FEATURE] Made the page dynamic

* [LICENSE] Added License doc strings as suggested by AGPLv3 License

* predicts score

* crawler complete

* Website and crawler integrated

* SEO tags

* Cleaned query params(#57)

* Dockerfiles set up(#59)

* Improved UI

Co-authored-by: Shreyas Raviprasad <shreyasraviprasad457@gmail.com>
Co-authored-by: Sammith S Bharadwaj <54738235+SammithSB@users.noreply.github.com>
Co-authored-by: scientes <34819304+scientes@users.noreply.github.com>
Co-authored-by: Bastian <scientes12@gmail.com>
Co-authored-by: Daniel <54536136+DAN-329@users.noreply.github.com>
Co-authored-by: SammithSB <sammithsb@gmail.com>
roysti10 added a commit that referenced this pull request Jan 7, 2021
* [FEATURE] Made the page dynamic

* [LICENSE] Added License doc strings as suggested by AGPLv3 License

* predicts score

* crawler complete

* Website and crawler integrated

* SEO tags

* Cleaned query params(#57)

* Dockerfiles set up(#59)

* Improved UI

* [TEST] Added basic tests

Co-authored-by: Shreyas Raviprasad <shreyasraviprasad457@gmail.com>
Co-authored-by: Sammith S Bharadwaj <54738235+SammithSB@users.noreply.github.com>
Co-authored-by: scientes <34819304+scientes@users.noreply.github.com>
Co-authored-by: Bastian <scientes12@gmail.com>
Co-authored-by: Daniel <54536136+DAN-329@users.noreply.github.com>
Co-authored-by: SammithSB <sammithsb@gmail.com>
roysti10 added a commit that referenced this pull request Jan 7, 2021
* [FEATURE] Made the page dynamic

* [LICENSE] Added License doc strings as suggested by AGPLv3 License

* predicts score

* crawler complete

* Website and crawler integrated

* SEO tags

* Cleaned query params(#57)

* Dockerfiles set up(#59)

* Improved UI

* [TEST] Added basic tests

Co-authored-by: Shreyas Raviprasad <shreyasraviprasad457@gmail.com>
Co-authored-by: Sammith S Bharadwaj <54738235+SammithSB@users.noreply.github.com>
Co-authored-by: scientes <34819304+scientes@users.noreply.github.com>
Co-authored-by: Bastian <scientes12@gmail.com>
Co-authored-by: Daniel <54536136+DAN-329@users.noreply.github.com>
Co-authored-by: SammithSB <sammithsb@gmail.com>
@roysti10 roysti10 deleted the feature-final branch January 9, 2021 08:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

5 participants