[SERVICE-418] Have service deploy with empty app directory

[MichaelMCoates]

Checks our build environment and if the default URL has changed. If we're in production and that URL hasn't changed from the demo, return an empty array. Is this sufficient? Is there something I'm missing here? The provider works fine with this change.

[bryangaleopenfin]

Hmm, I read this story as meaning we wanted to have an empty directory JSON we could deploy, though I could be wrong.

In any case, it might be worth changing the name of the current directory JSON to indicate it's the development sample data JSON

[tomrobertsOF]

Additional process note: it doesn't seem worth opening draft PRs when the intention is to actually merge the changes. I feel like they should be for more in-progress/half-finished type stuff (the kind of ones where in the past we would have put "DO NOT MERGE" at the top), but open for a broader discussion if people disagree.

[MichaelMCoates]

Additional process note: it doesn't seem worth opening draft PRs when the intention is to actually merge the changes. I feel like they should be for more in-progress/half-finished type stuff (the kind of ones where in the past we would have put "DO NOT MERGE" at the top), but open for a broader discussion if people disagree.

Sounds good! Will do.

[MichaelMCoates]

Hmm, I read this story as meaning we wanted to have an empty directory JSON we could deploy, though I could be wrong.

In any case, it might be worth changing the name of the current directory JSON to indicate it's the development sample data JSON

True, I was confused as well. After talking to Phil, I think that this first pass will suffice until we establish true App Directory configuration.

Good point! Changed to sample-app-directory.json. Would dev-app-directory be better?

[tomrobertsOF]

I think I'd prefer dev-app-directory, but doesn't really matter since this won't be around too long either way.