replace v8-profiler with node.js v7.x compatible fork #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
v8-profiler had to be removed because it is not compatible with node.js v7.x: `npm install` fails with compilation errors of C source code. [0][1] risingstack fork includes a fix that has not been merged into node-inspector/v8-profiler yet. This is still compatible with Node.js v6.x. [0] node-inspector/v8-profiler#98 [1] node-inspector/v8-profiler#99
|
Thanks a lot for your help! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v8-profiler had to be removed because it is not compatible with node.js
v7.x:
npm installfails with compilation errors of C source code.[0][1]
risingstack fork includes a fix that has not been merged into
node-inspector/v8-profiler yet. This is still compatible with Node.js
v6.x.
[0] node-inspector/v8-profiler#98
[1] node-inspector/v8-profiler#99