Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Loras and TI downloads out-of-sync due to multiprocessing #128

Open
1 of 2 tasks
db0 opened this issue Dec 19, 2023 · 0 comments
Open
1 of 2 tasks

Loras and TI downloads out-of-sync due to multiprocessing #128

db0 opened this issue Dec 19, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@db0
Copy link
Member

db0 commented Dec 19, 2023 •
edited by tazlin
Loading

Currently Loras and TI MMs in different inference keep their own "knowledge" of ad-hoc downloads, which is probably a problem as they might be deleting each other's files and clobbering the saved file.

  • Synchronize read/writes with a multiprocess lock
  • Switch to single process handling of this (a 'download' process or similar) obviating the need to synchronize
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@db0 @tazlin