ArtPaint: change POWERPC/INTEL defines to use BYTE_ORDER == BIG_ENDIAN #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change __INTEL__ and __POWERPC__ preprocessor checks to use BYTE_ORDER == BIG_ENDIAN. This allows more generic support for architectures, and also fixes alpha compositing issue on x86_64 (and perhaps selection issue on x86). Fixes HaikuArchives#81
|
Actually most of POWERPC using reciprocal_of_square_root should stay as is. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change INTEL and POWERPC preprocessor checks to use BYTE_ORDER
== BIG_ENDIAN. This allows more generic support for architectures, and
also fixes alpha compositing issue on x86_64 (and perhaps selection
issue on x86).
Didn't change a couple of places where inline asm is used because that might still be specific to the PowerPC arch, but I changed the elif to just else so everything else besides POWERPC will just fall through.
Fixes #81