Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version with lots of improvements #15

Closed
wants to merge 0 commits into from

Conversation

Sylvain78
Copy link

Improvements.

Tested on x86_gcc2 and x86 ,bare metal installation

@@ -11,11 +11,12 @@
#include <File.h>
#include <String.h>
#include <vector>
using namespace std;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be better to use using std::vector.

@@ -11,9 +11,11 @@
#include <ScrollBar.h>
#include <InterfaceDefs.h>
#include <vector>
using namespace std;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here

@scottmc
Copy link
Member

scottmc commented Nov 4, 2021

@Sylvain78 ,
While you are updating this, you can decompile the rsrc file using 'rc' and turn it into an rdef file.
See: https://www.haiku-os.org/documents/dev/compile_them_resources - instructions for decompiling are at the end of the article. It's a good read and helps explain why we prefer to have rdef over rsrc files in git. Then you just update the makefile and it should take care of it for you. See other makefiles on haikuarchives that have rdef files present for examples.

Also see #14 there is a source zip file on the linked page there. To me it looks like an earlier rev. But the poster say that version is more stable. You might check it to see if there is anything on use in that source zip. If you check it over, you might comment on that issue regarding what you find and maybe we can close that one out.

@scottmc
Copy link
Member

scottmc commented Nov 4, 2021

Also, I see you did your work in master. We prefer you follow the HaikuPorts/HaikuArchives development model:
https://github.com/haikuports/haikuports/wiki/DevelopmentModel

Don't worry about it for this PR, but once this gets merged, start doing future work in feature branches. After you do a few Pull Requests following this model you will get the hang of how it works.

@waddlesplash
Copy link
Member

Also, I see you did your work in master. We prefer you follow the HaikuPorts/HaikuArchives development model:

Ultimately it does not make much of a difference what branch a PR comes from for us; it just makes it easier on the person sending PRs to reset state once the PR has been merged.

Makefile Outdated
Src/Source/Prefs.cpp \
Src/Source/PrefsListItem.cpp \
Src/Source/PrefsListView.cpp \
Src/Source/PrefsWindow.cpp

# Specify the resource definition files to use. Full or relative paths can be
# used.
RDEFS =
Copy link
Member

@scottmc scottmc Nov 5, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Switch to use the rdef instead of rsrc"

RDEFS = BeTeX.rdef

RSRC =

and then you can delete the BeTeX.rsrc file from the repo, it would be regenerated when running make.

@Begasus
Copy link

Begasus commented May 27, 2022

Any progress here? With the open PR at haikuports (and the above fix for 32bit) it builds OK and works fine, current version doesn't let me open tex files, with these changes (and the work done on texlive/latex2html) it works quite well.

@scottmc
Copy link
Member

scottmc commented Oct 19, 2022

What's the status on this one? Do these changes still work, what is left to be done? Is this ready for merge?

@Begasus
Copy link

Begasus commented Dec 3, 2022

Patch doesn't apply, getting fails on Makefile (did a srcGitRev with latest commit and this PR as a patch)

@Sylvain78 Sylvain78 closed this Jul 25, 2023
@Sylvain78 Sylvain78 force-pushed the master branch 2 times, most recently from 44dc972 to e889633 Compare July 25, 2023 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants