Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change tint colour of deleted events #113

Closed
humdingerb opened this issue Dec 19, 2021 · 3 comments
Closed

Change tint colour of deleted events #113

humdingerb opened this issue Dec 19, 2021 · 3 comments

Comments

@humdingerb
Copy link
Member

With Haiku's default theme, the background colour of deleted events is quite similar to the background of a selected item. Therefore a selected item appears almost like a deleted item:

screenshot2

It's not the exact grey, but one can get confused.
Maybe a bit of red could be mixed in the colour of hidden/deleted events?

@humdingerb
Copy link
Member Author

screenshot3

This is with a

	if (severity >= 1)
		bgColor.red =- 5;

in EventListItem.cpp#L65

I have to admit, I don't quite understand why it's not bgColor.red =+ 5 to increase the red part of the colour and why lower values tint deeper than higher values... :)

What do you say, @JadedCtrl ?

@pulkomandy
Copy link
Member

If you want to increase, use += (or -= to decrease). What you have here just sets the color to +5 (which is quite dark) or -5 (which will overflow and become 250, quite light), ignoring the previous value.

@humdingerb
Copy link
Member Author

See, I am a crappy programmer... :)
I guess one has to find a more sophisticated solution to account for overflowing values. Help wanted...
It's nice that the Appearance prefs change colours live. Just twiddle the sliders for "List background" and see the changes.

humdingerb pushed a commit to humdingerb/Calendar that referenced this issue Dec 20, 2021
to avoid them being mistaken as selected items.
Fixes HaikuArchives#113
humdingerb pushed a commit to humdingerb/Calendar that referenced this issue Dec 20, 2021
to avoid them being mistaken as selected items.
Fixes HaikuArchives#113
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants