-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Swap forward slash with division slash in filename #96
Swap forward slash with division slash in filename #96
Conversation
I don't know, this works but it could also be a bit confusing? |
Yes, I agree, it seems rather confusing. |
Works on my end, clever workaround! If it's confusing because the user can't tell a substitution happened, maybe a more obvious character like the box-drawing slash [╱] could be used instead? |
Yes, it might be a bit confusing. Keep in mind these are just going to be swapped into the filenames of events. But that also means they will then be query-able. Maybe we should also add an attribute that contains the actual event name? Here's a few possible characters we could swap it to
Let's think about it for a couple days. Other comments? Other possible subs? |
Using _ in the filename and having the full name as a separate file attribute would be less confusing, I think? |
Event's real names are stored in "Event:Name"― the file-name is completely seperate. So if the user changes the event name, only the attribute will change. Come to think of it, I don't think the substitution would really add confusion, it'd just look pretty. |
Better fix for #82?
BeFS supports all UTF-8 characters except forward slash. So just swap it out for something that looks a lot like it... the division slash.
Did a quick test and it seems to work. Try making a new event with a slashed date in it such as Birthday 11/22/21 and then deleted the event. It shows up in trash with the division slash in place of the forward slash. Restoring it and then checking in Calendar for the event, it shows back up with the forward slashes in the event name.
@JadedCtrl please check and make sure it works for you.