Fixes #36
Closed
Fixes #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@humdingerb, along with the others could you please check the catkeys commit? I am unable to build with reference errors. I'm sure I'm missing something obvious. |
bitigchi
force-pushed
the
fixes
branch
3 times, most recently
from
2d1d435
to
b4cca95
Compare
humdingerb
requested changes
Mar 14, 2024
|
Is there a good similar project to check-out for layout kit? I'd like to fix the layout afterwards. |
|
Please rebase on master to get the CI build testing. |
bitigchi
force-pushed
the
fixes
branch
3 times, most recently
from
07e10e4
to
3984fc2
Compare
- Refactor strings according to Haiku HIG
|
Please reference #33 if that's supposed to be fixed with this PR. |
Done. |
korli
reviewed
Mar 18, 2024
bitigchi
force-pushed
the
fixes
branch
2 times, most recently
from
55b2a10
to
d823c2b
Compare
|
Merged manually in master. Thanks! |
|
@bitigchi just saw that you added Setttings/SettingsWindows in the commit "Change pointer alignment to left". That's unfortunate. They weren't added to the build anyway. |
|
Ah I see. That was an initial refactor but never got around to finish it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #33.