Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only the last row in the "Edit rule" window can be removed. #35

Closed
owenca opened this issue Jun 20, 2017 · 7 comments
Closed

Only the last row in the "Edit rule" window can be removed. #35

owenca opened this issue Jun 20, 2017 · 7 comments

Comments

@owenca
Copy link
Contributor

owenca commented Jun 20, 2017

Replace the Add/Remove buttons with one +/- button per row so that any row can be removed and a new row can be added below any row. (See issue #11.)

@owenca
Copy link
Contributor Author

owenca commented Jun 21, 2017

It seems there is a bug in the layout builder. I set the max size for the "-" button, but the layout builder still uses the default button size:
minus

When the default button size is used for both buttons:
default

When the max size are set for both buttons:
both

Is there a way to work around this?

@humdingerb
Copy link
Member

Without having tried it, maybe add a high weight, like 100.0, to the text control when .Add'ing it.

@humdingerb
Copy link
Member

I commented on your owenca@843a74e

I cheated by looking at the "Repositories" prefs code... :)

@owenca
Copy link
Contributor Author

owenca commented Jun 23, 2017

Thanks! And the Haiku Book really needs to be fixed. Such a basic omission caused hours of frustration and your time looking into it!!
setexplicitysize missing

@owenca
Copy link
Contributor Author

owenca commented Jun 23, 2017

Just to be clear, I was talking about the BView::SetExplicitSize function.

@humdingerb
Copy link
Member

Yes. The API docs are still incomplete and could use some love. Patches in that area are very welcome... :)
I do see, of course, that it needs quite some insight wrt the workings of the layout management to be able to contribute there. I'm surely not up to it...

@humdingerb
Copy link
Member

Owenca added +/- buttons to all rows. So, fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants