Don't show generic files including symlinks to them in Archive and #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this PR would make things worse. Please see #117. |
|
So it seems that the user can still make use of zip/script files in Filer even if Haiku treats them as generic files. I have commented out the code in case it's needed in the future when Haiku can recognize zip/script files from other file systems. |
|
OK. Can you add a short comment in the code as explanation? |
(inlcuding symlinks to them) in Archive and Command text entries. Also, treat empty MIME type as generic files for Achive and Command file panels. ok
|
Done. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Command file panels.
Don't accept drag&drop'ed generic files (inlcuding symlinks to them) in
Archive and Command text entries.