Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't show generic files including symlinks to them in Archive and #116

Merged
merged 1 commit into from
Aug 27, 2017

Conversation

owenca
Copy link
Contributor

@owenca owenca commented Aug 25, 2017

Command file panels.

Don't accept drag&drop'ed generic files (inlcuding symlinks to them) in
Archive and Command text entries.

@humdingerb
Copy link
Member

I think this PR would make things worse. Please see #117.

@owenca
Copy link
Contributor Author

owenca commented Aug 26, 2017

So it seems that the user can still make use of zip/script files in Filer even if Haiku treats them as generic files. I have commented out the code in case it's needed in the future when Haiku can recognize zip/script files from other file systems.

@humdingerb
Copy link
Member

OK. Can you add a short comment in the code as explanation?

(inlcuding symlinks to them) in Archive and Command text entries.

Also, treat empty MIME type as generic files for Achive and Command file
panels.

ok
@owenca
Copy link
Contributor Author

owenca commented Aug 27, 2017

Done.

@humdingerb humdingerb merged commit d329b56 into HaikuArchives:master Aug 27, 2017
@humdingerb
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants