Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes issue #64: #70

Merged
merged 1 commit into from
Jul 19, 2017
Merged

Fixes issue #64: #70

merged 1 commit into from
Jul 19, 2017

Conversation

owenca
Copy link
Contributor

@owenca owenca commented Jul 18, 2017

Only allow decimal digits 0-9 in the text control for the Size test.

@owenca owenca mentioned this pull request Jul 18, 2017
	Only allow decimal digits in text control for size test.
@humdingerb
Copy link
Member

I found one problem:
The disallowing of non-digits in the "Size" text control works when creating a new rule or editing a rule the first time after Filer is launched. But after that, editing a rule does again allow non-digits. The value with the non-digits also gets saved with the rule.

And: could you title your PRs more detailed in the future, please. "Fixes #64" isn't very helpful when someone looks over a list of commits. Maybe "Disallow non-digits in size test (issue #64)", then add more info in the body of the commit message if you'd like to explain further, or simply add "Fixes issue #64." if it's all obvious.

@owenca
Copy link
Contributor Author

owenca commented Jul 19, 2017

Sorry that I forgot a list of commits would only show the first line of the commit message. I will update it when updating the commit to fix the bug you found.

@owenca
Copy link
Contributor Author

owenca commented Jul 19, 2017

Fixed.

@humdingerb humdingerb merged commit 3e99669 into HaikuArchives:master Jul 19, 2017
@humdingerb
Copy link
Member

Works! Thanks very much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants