fix: prevent crashes when choosing monaco snippets with mouse #877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stristr
reviewed
Oct 23, 2018
| element.addEventListener('mousedown', (mouseDownEvent) => { | ||
| mouseDownEvent.preventDefault(); | ||
| mouseDownEvent.stopImmediatePropagation(); | ||
| }); |
There was a problem hiding this comment.
Reasonably confident these elements and their listeners go out of scope after the menu closes, so LGTM.
There was a problem hiding this comment.
You are 💯 right, I can confirm that they do.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OK to merge.
Short review.
Summary of changes:
Fixes crash: Monaco bug: Error: Invalid start index: 2
There's an issue (now fixed) in vscode which causes the editor to crash when selecting autocompletion items with the mouse.
monacois built from thevscodesource as a separate package from time to time, but that fix is not released yet, so for the moment I'm disabling the ability to select autocompletion items with the mouse.I created an issue in the
monacorepo asking for a new release, but I don't expect that to occur any time soon.Regressions to look for:
Completed checkin tasks:
changelog/public/latest.json